Review Request 127523: Only link with MYSQL_EMBEDDED_LIBRARIES if WITH_MYSQL_EMBEDDED

[Myriam Schweingruber]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127523/#review94120
-----------------------------------------------------------



hm, I fail to see why you would not build amarok with MySQL embedded, as that is the default database. Could you please specify why this patch is needed?

- Myriam Schweingruber


On March 29, 2016, 6:27 p.m., Matt Whitlock wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127523/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 6:27 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This patch corrects a build failure when compiling Amarok without MySQL Embedded.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/mysqlcollection/CMakeLists.txt 244cde1 
> 
> Diff: https://git.reviewboard.kde.org/r/127523/diff/
> 
> 
> Testing
> -------
> 
> See [Gentoo bug 566980](https://bugs.gentoo.org/show_bug.cgi?id=566980).
> 
> 
> Thanks,
> 
> Matt Whitlock
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160329/5c24c08e/attachment.html>