Review Request 128248: Remove non SSL option for Wikipedia applet
Olivier Churlaud
olivier at churlaud.com
Mon Jun 20 22:17:51 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/
-----------------------------------------------------------
(Updated June 21, 2016, 12:17 a.m.)
Status
------
This change has been marked as submitted.
Review request for Amarok and Myriam Schweingruber.
Changes
-------
Submitted with commit 8c15258b28870b6d9990b24f87ce913e2049bac8 by Olivier CHURLAUD to branch master.
Bugs: 349313
https://bugs.kde.org/show_bug.cgi?id=349313
Repository: amarok
Description
-------
I removed every possibility to use non SSL links
Diffs
-----
src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0
src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df
src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc
src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b
Diff: https://git.reviewboard.kde.org/r/128248/diff/
Testing
-------
It compiles. However not tested, because make install always install in /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to mess my install.
Thanks,
Olivier Churlaud
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160620/276a99a6/attachment.html>
More information about the Amarok-devel
mailing list