Review Request 128248: Remove non SSL option for Wikipedia applet

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96755
-----------------------------------------------------------



Looks well, one minor thing below - unrelated change.

Also please mention:
BUG: 348313
..in the commit message and include a ChangeLog entry in the patch.


src/musicbrainz/MusicDNSAudioDecoder.cpp (line 226)
<https://git.reviewboard.kde.org/r/128248/#comment65359>

    This looks like an unrelated change. Please strip of a probably post as a separate patch. Applies also to the change few lines below.


- Matěj Laitl


On Čer. 19, 2016, 11:44 dop., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> -----------------------------------------------------------
> 
> (Updated Čer. 19, 2016, 11:44 dop.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 349313
>     https://bugs.kde.org/show_bug.cgi?id=349313
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> I removed every possibility to use non SSL links
> 
> 
> Diffs
> -----
> 
>   src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
>   src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
> 
> 
> Testing
> -------
> 
> It compiles. However not tested, because make install always install in /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to mess my install.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160620/58e839f0/attachment.html>