Review Request 128246: Lyrics browser switched to the same background of the every other context applet
Matěj Laitl
matej at laitl.cz
Sun Jun 19 13:53:58 UTC 2016
> On Čer. 19, 2016, 3:53 odp., Matěj Laitl wrote:
> > Although I'm not context view expert, this loks good to me, let's merge this and let wider user base test it.
I forgot: the patch fixes a bug, thuis should contain a ChangeLog entry.
- Matěj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128246/#review96718
-----------------------------------------------------------
On Čer. 19, 2016, 3:01 dop., Stefano Pettini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128246/
> -----------------------------------------------------------
>
> (Updated Čer. 19, 2016, 3:01 dop.)
>
>
> Review request for Amarok.
>
>
> Bugs: 314854
> https://bugs.kde.org/show_bug.cgi?id=314854
>
>
> Repository: amarok
>
>
> Description
> -------
>
> This makes the lyrics browser similar to every other context applet.
> Please note that, when editing lyrics, the default textbox background
> is still used.
>
>
> Diffs
> -----
>
> src/context/applets/lyrics/LyricsBrowser.cpp abcfe64
>
> Diff: https://git.reviewboard.kde.org/r/128246/diff/
>
>
> Testing
> -------
>
> Tested ONLY in the following environment:
> KDE Version: 4.14.16
> Qt Version: 4.8.7
>
> Tested with light and dark color scheme
> Tested use case of changing KDE color scheme while Amarok is running
> Tested the edit lyrics mode
>
>
> Thanks,
>
> Stefano Pettini
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160619/24a5d1b6/attachment.html>
More information about the Amarok-devel
mailing list