Review Request 127458: Fix for 2 warnings, one of them a probable bug

Stefano Pettini stefano.pettini at gmail.com
Fri Jun 17 21:46:21 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127458/
-----------------------------------------------------------

(Updated June 17, 2016, 11:46 p.m.)


Review request for Amarok.


Changes
-------

More warnings are fixed


Repository: amarok


Description
-------

This fixes two minor C++ warnings: one unused variable and another one about operator precedence. However I think the last one was I bug, that I think I fixed. It was about bpm in SqlScanProcessor


Diffs (updated)
-----

  src/configdialog/dialogs/DatabaseConfig.cpp 1cb2d97 
  src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp ea9c911 
  src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp 5cdb693 
  src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp 5b09f07 
  src/services/mp3tunes/libmp3tunes/harmony.c ead0345 
  src/statemanagement/DefaultApplicationController.cpp 5886789 

Diff: https://git.reviewboard.kde.org/r/127458/diff/


Testing
-------


Thanks,

Stefano Pettini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160617/961e2831/attachment.html>


More information about the Amarok-devel mailing list