Review Request 128246: Lyrics browser switched to the same background of the every other context applet

Stefano Pettini stefano.pettini at gmail.com
Sun Jul 10 21:13:11 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128246/
-----------------------------------------------------------

(Updated July 10, 2016, 11:13 p.m.)


Review request for Amarok.


Changes
-------

Rebased and updated ChangeLog


Bugs: 314854
    https://bugs.kde.org/show_bug.cgi?id=314854


Repository: amarok


Description
-------

This makes the lyrics browser similar to every other context applet.
Please note that, when editing lyrics, the default textbox background
is still used.


Diffs (updated)
-----

  ChangeLog 23599f1 
  src/context/applets/lyrics/LyricsBrowser.cpp abcfe64 

Diff: https://git.reviewboard.kde.org/r/128246/diff/


Testing
-------

Tested ONLY in the following environment:
KDE Version: 4.14.16
Qt Version: 4.8.7

Tested with light and dark color scheme
Tested use case of changing KDE color scheme while Amarok is running
Tested the edit lyrics mode


Thanks,

Stefano Pettini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160710/7054278c/attachment.html>


More information about the Amarok-devel mailing list