Review Request 128245: Length, but also any other numeric field, not properly handled in filter dialogs

[Stefano Pettini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128245/
-----------------------------------------------------------

(Updated Aug. 7, 2016, 9:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok.


Changes
-------

Submitted with commit 6c49cfdfd97faa146ce7b0d8e95ce2bf596f2b0d by Mat?j Laitl on behalf of Stefano Pettini to branch master.


Bugs: 341661
    https://bugs.kde.org/show_bug.cgi?id=341661


Repository: amarok


Description
-------

Every numeric field, like length, disc number and track number, were not properly parsed by the filter dialog or by the dynamic playlist dialog into the textual query string used to then apply the filter.

The bug was due to what sounds like an "optimization" that swapped the first and second value of a "between" condition, to make sure the smaller value was always the first value and the larger always the second. The problem was that this was applied also to non-between conditions, actually swapping the lenth or disc number with 0, making 0 appear in the textual representation of the condition.

The fix makes sure that "optimization" is applied only in case of actual "between" conditions, leaving the values "unoptimized" for any other kind of condition (=, <, > and similar).


Diffs
-----

  ChangeLog 23599f1 
  src/widgets/MetaQueryWidget.cpp abce6b7 

Diff: https://git.reviewboard.kde.org/r/128245/diff/


Testing
-------

Verified in both filter dialog and dynamic playlist dialog.


Thanks,

Stefano Pettini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160807/86d1450d/attachment.html>