Review Request 128565: Organize tracks and Guess tags presets persisted properly

[Stefano Pettini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128565/
-----------------------------------------------------------

(Updated Aug. 4, 2016, 2:08 a.m.)


Review request for Amarok.


Changes
-------

Presets persistance logic further improved: presets are always persisted, custom presed only when accepting the dialog.


Bugs: 226144
    https://bugs.kde.org/show_bug.cgi?id=226144


Repository: amarok


Description
-------

FilenameLayoutWidget is reworked to properly manage the combobox of presets.

Presets are persisted and shared between "organize tracks" and "guess tags",
but the custom preset and other dialog settings are not.

Add/Update/Remove work properly. Clicking on a preset name in the combobox
resets the custom pattern to the preset value.

Modified presets are persisted even if dialog windows are cancelled.


Diffs (updated)
-----

  ChangeLog 23599f1 
  src/dialogs/OrganizeCollectionDialog.h 88fa08d 
  src/dialogs/OrganizeCollectionDialog.cpp 973e9cb 
  src/widgets/FilenameLayoutWidget.h 9fb2678 
  src/widgets/FilenameLayoutWidget.cpp 8d189cf 

Diff: https://git.reviewboard.kde.org/r/128565/diff/


Testing
-------

A lot of testing was done, like:
- adding/updating/removing presets.
- if settings are persisted and shared.
- if custom patterns are persisted and not shared.
- resetting a modified pattern to its defualt.
- cancelling dialogs, modified presets are kept.


Thanks,

Stefano Pettini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160804/dac10b5c/attachment.html>