Review Request 127468: Fix for the infinite loop in case a home-burned or old audio CD is inserted

[Heiko Becker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127468/#review94192
-----------------------------------------------------------


Ship it!




Fixes the bug as advertised. Do you have commit access or should I push this in your name?

- Heiko Becker


On März 23, 2016, 8:32 nachm., Stefano Pettini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127468/
> -----------------------------------------------------------
> 
> (Updated März 23, 2016, 8:32 nachm.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 339190
>     https://bugs.kde.org/show_bug.cgi?id=339190
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Home-burned or old audio CDs usually don't have CDTEXT, that is what was triggering the bug.
> The bug was releted to poor management of track names, that are generated using the pattern "Track%1.wav".
> The audiocd:/ KIO protocol requires that a device is also added to the URL, and this was not done everywhere.
> Lack of device was triggering an unexpected/strange behaviour in some KDE function making Amarok enter an infinite loop.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/audiocd/AudioCdCollection.h dc2cad7 
>   src/core-impl/collections/audiocd/AudioCdCollection.cpp 3dfa7c3 
> 
> Diff: https://git.reviewboard.kde.org/r/127468/diff/
> 
> 
> Testing
> -------
> 
> First I reproduced the bug with an original CD 100% of the times. It was triggered in case the CD didn't have any CDTEXT. Only in that case the noInfoAvailable function was invoked.
> After fixing it, I verified that it works as expected both with CDs with CDTEXT and CDs without it.
> 
> The "Copy to collection" feature is also tested with CDs with and without CDTEXT and multiple encodings (ogg, flac, wav). Before it was not working, now it does.
> 
> 
> Thanks,
> 
> Stefano Pettini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160401/42d5f0e5/attachment.html>