Review Request 125394: CMake shows LibLastFm not found warning on some systems.

[Myriam Schweingruber]

> On Sept. 25, 2015, 9:46 p.m., Myriam Schweingruber wrote:
> > erm, /usr/local/include? are you sure? That folder is normally empty, I guess you meant /usr/include/liblastfm5, no?
> 
> Aditya Dev Sharma wrote:
>     I'm quite sure about it. /usr/local/include was empty initially. But installing LastFm (the Qt5 version) installed it there in /usr/local/include/lastfm5
> 
> Olivier Churlaud wrote:
>     I think it depends of how you install it. If you compile it manually (or use yaourt on arch) it goes to /usr/local/include. If you install it from a package, it goes to /usr/include.

Yes, I know that, but we shouldn't make our code depend on local installations, that would be hell for the packagers.


- Myriam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125394/#review85938
-----------------------------------------------------------


On Sept. 25, 2015, 10:42 p.m., Aditya Dev Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125394/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 10:42 p.m.)
> 
> 
> Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam Schweingruber.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> We need the Qt5 version of LibLastFm (ie liblastfm5) . Even after installing the Qt5 version of the package, CMake showed not found.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindLibLastFm.cmake 8fa607b 
> 
> Diff: https://git.reviewboard.kde.org/r/125394/diff/
> 
> 
> Testing
> -------
> 
> Builds 100 %
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150926/16a00699/attachment.html>