Port KF5

[Olivier Churlaud]

Dear Rishabh,

I apology, I did the backtrace command in gdb, and had the exact same 
output as you...

The error comes from this code:

     //We need to set fixed widths initially, just until the main window 
has been properly laid out. As soon as this has
     //happened, we will unlock these sizes again so that the elements 
can be resized by the user.
     const int mins[3] = { m_browserDock.data()->minimumWidth(), 
m_contextDock.data()->minimumWidth(), 
m_playlistDock.data()->minimumWidth() };
     const int maxs[3] = { m_browserDock.data()->maximumWidth(), 
m_contextDock.data()->maximumWidth(), 
m_playlistDock.data()->maximumWidth() };

     m_browserDock.data()->setFixedWidth( widgetWidth * 0.65 );
     m_contextDock.data()->setFixedWidth( widgetWidth * 1.7 + leftover );
     m_playlistDock.data()->setFixedWidth( widgetWidth * 0.65 );

     // Important: We need to activate the layout we have just set
     layout()->activate();

     m_browserDock.data()->setMinimumWidth( mins[0] ); 
m_browserDock.data()->setMaximumWidth( maxs[0] );
     m_contextDock.data()->setMinimumWidth( mins[1] ); 
m_contextDock.data()->setMaximumWidth( maxs[1] );
     m_playlistDock.data()->setMinimumWidth( mins[2] ); 
m_playlistDock.data()->setMaximumWidth( maxs[2] );

which uses m_contextDock, from the /src/context folder which is not 
compiled... This means that we need to port context to qml first or 
comment this part;

It also means that the different parts of the project are not as 
independent as expected.

Cheers.
Olivier


Le 13/09/2015 18:56, Olivier Churlaud a écrit :
> Here is my full log :
> http://pastebin.com/Z28JJERv
>
> I think you didn't apply the diff well....
>
> Le 13/09/2015 18:52, Olivier Churlaud a écrit :
>> Hi Ribash,
>>
>> How come the line was missing? Did you apply the diff to the project 
>> ? Didi you use the second one (don't take care of the 1st)
>>
>> Your log is very interesting, what debugger do you use? With gdb, I 
>> can't get such a deep description (but I may not know how to use it 
>> well).
>>
>> With such a trace, you might be able to find the error, and correct it.
>>
>> If you need any help, do not hesitate,
>>
>> Have fun!
>> Olivier
>>
>> Le 13/09/2015 17:34, RISHABH GUPTA a écrit :
>>>
>>>
>>>     >> here's the output
>>>     >> http://pastebin.com/5StyEUth
>>>     > Huuu.... Wait, it's not possible. My segfault doesn't happen in
>>>     > handleCliArgs() but way after... It means that I left a bug, that
>>>     > works on my system but not yours OR that something is wrong on
>>>     your
>>>     > side. Please investigate why this happen, I'll do this on my
>>>     side too.
>>>
>>>     Ok, in the code you have this:
>>>
>>>
>>>     QCommandLineParser parser;
>>>     parser.addVersionOption();
>>>     parser.addHelpOption();
>>>
>>>     aboutData.setupCommandLine(&parser);
>>>     app.initCliArgs(&parser);
>>>     parser.process(app);
>>>     aboutData.processCommandLine(&parser);
>>>
>>>     so normally, the parser is given in initCliArgs() to App, and the
>>>     options are added here.
>>>
>>>     app.handleCliArgs(cwd) should be called after initCliArgs() (when
>>>     continueInit() is called) and m_args should point to parser:
>>>     your error
>>>     shouldn't be there.. (or I did something wrong in the code, but
>>>     I don't
>>>     know what)
>>>
>>>     So I advise you to check very specifically that every option is
>>>     called,
>>>     and debug that m_args points well toward the parser from the main.
>>>
>>>
>>> In my main.cpp app.initcliargs(&parser) was missing after adding it 
>>> this is the output
>>> http://pastebin.com/Ka7cz7rZ
>>>
>>>     Cheers!
>>>     Olivier
>>>
>>>
>>> thanks,
>>> rishabh
>>>
>>
>>
>>
>> _______________________________________________
>> Amarok-devel mailing list
>> Amarok-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150913/f1b25925/attachment.html>