Review Request 125126: Port of main.cpp and App class

Olivier Churlaud olivier at churlaud.com
Wed Sep 9 22:08:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125126/
-----------------------------------------------------------

Review request for Amarok.


Repository: amarok


Description
-------

Port of main.cpp and App


Diffs
-----

  src/App.h 2089981 
  src/App.cpp 6028bc8 
  src/CMakeLists.txt afeef4a 
  src/main.cpp 385e047 
  src/org.kde.amarok.desktop 433c757 

Diff: https://git.reviewboard.kde.org/r/125126/diff/


Testing
-------

Here is my full output... Please tell me if it seems correct or not. 

http://pastebin.com/naduYv8M

There are still some small things that aren't port. (for instance calling a second instance to use the --play, -r,...)


Thanks,

Olivier Churlaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150909/eb87e0e7/attachment-0001.html>


More information about the Amarok-devel mailing list