kf5 port continued(stefan derkits)

[RISHABH GUPTA]

>
>
> Message: 1
> Date: Sun, 6 Sep 2015 02:22:43 +0200
> From: Stefan Derkits <stefan at derkits.at>
> To: amarok-devel at kde.org
> Subject: KF5 port continued
> Message-ID: <55EB8753.5080706 at derkits.at>
> Content-Type: text/plain; charset="utf-8"
>
> Hey,
>
> hello,


> thanks Somsubhra for making the port compile.
>
> I compiled it and got a segfault related to liblastfm. Please note that
> the Qt5 liblastfm is called liblastfm5.so, I changed this for lastfm &
> mygpo-qt in CMakeLists
>
>
after applying Somsubhra's patch the make command  didn't produce any
error, the code  built completely .I didn't get any segfault as you have
mentioned .Did you make any other changes ?



> QJson is also not ported to Qt5 [there exists JSON functionality in Qt5
> directly) (can someone find out if it is really only used for the
> playdar collection?)
>
> Qjson package is  included only in the cmakelists.txt of playdar
collection. So i guess its only used for playdar collection



> After these two CMake fixes, I get a segfault in:
> main.cpp line 311
>
> I think it is related to the following:
> KAboutData is KF5 only but KUniqueApplication is KDELibs4Support only.
> The KDELibs4Support version of KAboutData is k4aboutdata.h &
> K4AboutData. Tried to only use k4aboutdata, Amarok has problems to
> compile OcsData.h
>
> Couldn't get here as the code compiled fine.If you made any other changes
then please share .


> So next porting steps seem to be:
> Change to K4AboutData and see if it fixes this segfault or port away
> from KUniqueApplication
>
> Stefan
>
> thank you,
rishabh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150907/ba50e912/attachment.html>