Review Request 125593: removed the Line that deleted m_args

rishabh gupta rishabh9511 at gmail.com
Mon Oct 12 13:03:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125593/
-----------------------------------------------------------

(Updated Oct. 12, 2015, 1:03 p.m.)


Review request for Amarok, Stefan Derkits and Olivier Churlaud.


Changes
-------

commented the line that deleted m_args...we might need it later.


Repository: amarok


Description
-------

on choosing to quit amarok from amarok's menu the progaram recieves signal SIGABRT.


Diffs (updated)
-----

  src/App.cpp b3d14da 

Diff: https://git.reviewboard.kde.org/r/125593/diff/


Testing
-------

builds 100%

the reason it was recieving sigabrt was m_args was being deleted.Maybe not deleting is not the right option but it quits normally now


Thanks,

rishabh  gupta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151012/867cbb9e/attachment.html>


More information about the Amarok-devel mailing list