Review Request 126195: fix filename colouring in the tag guessing dialog
Matthias Berndt
matthias_berndt at gmx.de
Sat Nov 28 22:04:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126195/
-----------------------------------------------------------
Review request for Amarok.
Repository: amarok
Description
-------
Currently in the tag guessing dialog a coloured version of the file name
is shown. The colours indicate where the individual tag values are taken
from. If any of the tag values appears twice in the file name, both
occurrences are coloured, even though only one should be, i. e. the one
he tag value is actually being derived from. This patch fixes this issue
Diffs
-----
shared/TagsFromFileNameGuesser.h 0aa94c5
shared/TagsFromFileNameGuesser.cpp 1152271
src/dialogs/TagDialog.cpp 54e8957
src/dialogs/TagGuesser.h 55f5bfd
src/dialogs/TagGuesser.cpp 5b3267f
src/dialogs/TagGuesserDialog.h 2c1a753
src/dialogs/TagGuesserDialog.cpp e6c427e
tests/TestTagGuesser.cpp 620ff98
Diff: https://git.reviewboard.kde.org/r/126195/diff/
Testing
-------
Thanks,
Matthias Berndt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151128/1d5f9b3e/attachment.html>
More information about the Amarok-devel
mailing list