Review Request 126128: Port EqualizerDialog
Ralf Engels
ralf-engels at gmx.de
Sun Nov 22 20:41:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126128/#review88699
-----------------------------------------------------------
Could you also state a reason for the change?
Is that just to get rid of the usage of a KDE dialog where a "plain" Qt dialog is sufficient?
- Ralf Engels
On Nov. 21, 2015, 3:02 nachm., Olivier Churlaud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126128/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2015, 3:02 nachm.)
>
>
> Review request for Amarok and Ralf Engels.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> EqualizerDialog is now a QDialog
>
>
> Diffs
> -----
>
> src/dialogs/EqualizerDialog.h 53654b6
> src/dialogs/EqualizerDialog.cpp 936fd20
> src/dialogs/EqualizerDialog.ui 7fc5a7d
>
> Diff: https://git.reviewboard.kde.org/r/126128/diff/
>
>
> Testing
> -------
>
> Compiles, run, behave correctly.
>
>
> Thanks,
>
> Olivier Churlaud
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151122/0f4fecd1/attachment.html>
More information about the Amarok-devel
mailing list