Review Request 125126: Port of main.cpp and App class
Olivier Churlaud
olivier at churlaud.com
Mon Nov 9 18:01:51 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125126/
-----------------------------------------------------------
(Updated nov. 9, 2015, 7:01 après-midi)
Status
------
This change has been marked as submitted.
Review request for Amarok.
Repository: amarok
Description
-------
Port of main.cpp and App
It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().
I'm not able to trace it further.
Please help me to port well the main + App class so that the play, pause (and so one) commands are well read and to deal correctly with the unique/multiple instance.
Diffs
-----
src/App.h 2089981
src/App.cpp 6028bc8
src/CMakeLists.txt afeef4a
src/MainWindow.cpp d3bbc0b
src/PluginManager.cpp a9a1c47
src/TrayIcon.cpp be25497
src/aboutdialog/libattica-ocsclient/activitylistjob.cpp 77044cf
src/aboutdialog/libattica-ocsclient/categorylistjob.cpp 427011e
src/aboutdialog/libattica-ocsclient/contentjob.cpp c307e07
src/aboutdialog/libattica-ocsclient/contentlistjob.cpp d371db4
src/aboutdialog/libattica-ocsclient/folderlistjob.cpp dc2c137
src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp f678b56
src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp a7d6b95
src/aboutdialog/libattica-ocsclient/messagelistjob.cpp 372412d
src/aboutdialog/libattica-ocsclient/personjob.cpp 455178c
src/aboutdialog/libattica-ocsclient/personlistjob.cpp 005542b
src/aboutdialog/libattica-ocsclient/postjob.cpp cce72a3
src/amarok.desktop 433c757
src/browsers/filebrowser/FileBrowser.cpp 3d40d9b
src/configdialog/dialogs/ScriptsConfig.cpp bbec667
src/context/engines/songkick/SongkickEngine.cpp 2291719
src/core-impl/collections/db/sql/SqlCollectionLocation.cpp fe6bafd
src/core/podcasts/PodcastReader.cpp 409fc62
src/core/support/Components.cpp 9f97eb6
src/main.cpp 385e047
src/org.kde.amarok.desktop PRE-CREATION
src/scanner/AbstractDirectoryWatcher.cpp 168c68a
src/scanner/GenericScanManager.cpp 75a22cc
src/scanner/GenericScannerJob.cpp a4558fd
src/scripting/scriptmanager/ScriptManager.cpp bb62be1
src/services/ServiceAlbumCoverDownloader.cpp d499f62
src/services/lastfm/biases/WeeklyTopBias.cpp a12f9f7
src/services/magnatune/MagnatuneAlbumDownloader.cpp 5fc6584
src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 0c5913a
src/services/opmldirectory/OpmlDirectoryInfoParser.cpp f6ac752
Diff: https://git.reviewboard.kde.org/r/125126/diff/
Testing
-------
It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().
I'm not able to trace it further.
Thanks,
Olivier Churlaud
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151109/08a26c38/attachment.html>
More information about the Amarok-devel
mailing list