Review Request 125940: Fix mygpo-qt5 library finding
Stefan Derkits
stefan at derkits.at
Tue Nov 3 22:04:12 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125940/#review87967
-----------------------------------------------------------
cmake/modules/FindLibmygpo-qt.cmake (line 18)
<https://git.reviewboard.kde.org/r/125940/#comment60350>
seems to be installed in a non-standard path by the distribution, because the standard path is mygpo-qt for both the qt4 & qt5 build :( which distribution are you using?
probably I should fix this upstream, bump the version number and then we can merge this review request
- Stefan Derkits
On Nov. 3, 2015, 9:46 p.m., Andrea Scarpino wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125940/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 9:46 p.m.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> mygpo built with qt5 installs under /usr/include/mygpo-qt5 instead of mygpo-qt.
>
>
> Also, update the module name used in CMakeLists.txt
>
>
> Diffs
> -----
>
> CMakeLists.txt 8cf9af3
> cmake/modules/FindLibmygpo-qt.cmake a1af542
>
> Diff: https://git.reviewboard.kde.org/r/125940/diff/
>
>
> Testing
> -------
>
> mygpo-qt5 is found.
>
>
> Thanks,
>
> Andrea Scarpino
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151103/57324b60/attachment.html>
More information about the Amarok-devel
mailing list