Review Request 125937: Port away from qjson

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125937/#review87963
-----------------------------------------------------------



src/core-impl/collections/playdarcollection/support/Controller.cpp (line 137)
<https://git.reviewboard.kde.org/r/125937/#comment60349>

    Why a pointer?



src/core-impl/collections/playdarcollection/support/Controller.cpp (line 144)
<https://git.reviewboard.kde.org/r/125937/#comment60348>

    Why aren't you using json.object() and then operate on the QJsonObject? Saves you quite some conversions there


- Kai Uwe Broulik


On Nov. 3, 2015, 8:27 nachm., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125937/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 8:27 nachm.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> We don't need anymore qjson. Use QJsonDocument instead.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQJSON.cmake 5fafca5 
>   src/core-impl/collections/playdarcollection/CMakeLists.txt 06def29 
>   src/core-impl/collections/playdarcollection/support/Controller.cpp d584ac1 
>   src/core-impl/collections/playdarcollection/support/Query.cpp 5a28004 
> 
> Diff: https://git.reviewboard.kde.org/r/125937/diff/
> 
> 
> Testing
> -------
> 
> Build.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151103/87942607/attachment.html>