Review Request 122797: Fix Gpodder credential service without kwallet

Giuseppe Silletti sillettig at gmail.com
Tue Mar 3 21:14:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122797/
-----------------------------------------------------------

Review request for Amarok.


Repository: amarok


Description
-------

Before to fix this bug, the gpodder plugin had problems with saving username and password in plain text. 

There were two problems: 

1) A useless space for the variable m_ignoreWallet was saved in the config file 
2) The saving of the credential in plain text where made in the wrong way. 
Now it is called the function askAboutMissingKWallet(), that make the use see a dialog windows where is asked to save the credential in plain text. 
Credential are now saved in the textDialogYes slot.


Diffs
-----

  src/services/gpodder/GpodderServiceConfig.cpp 9098d59 

Diff: https://git.reviewboard.kde.org/r/122797/diff/


Testing
-------

It simply works now


Thanks,

Giuseppe Silletti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150303/42a97efd/attachment.html>


More information about the Amarok-devel mailing list