Review Request 121962: Use QCA to generate hashes for the Ampache login process

[Myriam Schweingruber]

> On Jan. 19, 2015, 10:23 a.m., Luca Beltrame wrote:
> > Ping?

I am not the strongest when it comes to reviewing code, but I can't see obvious errors, and since it works...
Ship it!


- Myriam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121962/#review74295
-----------------------------------------------------------


On Jan. 10, 2015, 11:02 a.m., Luca Beltrame wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121962/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 11:02 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> The sha256() function provided to generate hashes for Ampache is incorrect (generates wrong hashes), and thus will not generate a proper passphrase for Ampache versions greater than 35, which will fail with an "incorrect password" message. 
> 
> The solution is to use the hash functions provided by QCA, which work correctly. However this adds a (conditional and optional) dependency to QCA to build the Ampache plugin.
> 
> 
> Diffs
> -----
> 
>   src/services/CMakeLists.txt 83ccdfb 
>   src/services/ampache/AmpacheAccountLogin.cpp 26aebed 
>   src/services/ampache/CMakeLists.txt dd298e8 
>   src/services/ampache/sha256/sha256.h 9bf7387 
>   src/services/ampache/sha256/sha256.cpp 01b3764 
> 
> Diff: https://git.reviewboard.kde.org/r/121962/diff/
> 
> 
> Testing
> -------
> 
> Compiles, a non-working login with Ampache (git master) now works correctly.
> 
> 
> Thanks,
> 
> Luca Beltrame
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150130/cecb5bc0/attachment.html>