Review Request 121962: Use QCA to generate hashes for the Ampache login process

[Luca Beltrame]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121962/
-----------------------------------------------------------

(Updated Gen. 10, 2015, 10:02 a.m.)


Review request for Amarok.


Changes
-------

Don't look for QCA2 twice.


Repository: amarok


Description
-------

The sha256() function provided to generate hashes for Ampache is incorrect (generates wrong hashes), and thus will not generate a proper passphrase for Ampache versions greater than 35, which will fail with an "incorrect password" message. 

The solution is to use the hash functions provided by QCA, which work correctly. However this adds a (conditional and optional) dependency to QCA to build the Ampache plugin.


Diffs (updated)
-----

  src/services/CMakeLists.txt 83ccdfb 
  src/services/ampache/AmpacheAccountLogin.cpp 26aebed 
  src/services/ampache/CMakeLists.txt dd298e8 
  src/services/ampache/sha256/sha256.h 9bf7387 
  src/services/ampache/sha256/sha256.cpp 01b3764 

Diff: https://git.reviewboard.kde.org/r/121962/diff/


Testing
-------

Compiles, a non-working login with Ampache (git master) now works correctly.


Thanks,

Luca Beltrame

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150110/091f01f1/attachment.html>