Idea for the porting

[Stefan Derkits]

Hey,

On 2015-08-30 02:07, Stefan Derkits wrote:
> amarok sql collection

Olivier and me narrowed down the problem why the sql collection & the
sql storage plugins were not buidling:

in StorageFactory.h

#define AMAROK_EXPORT_STORAGE( classname, libname ) \
    K_PLUGIN_FACTORY( factory, registerPlugin<classname>(); ) \
            K_EXPORT_PLUGIN( factory( "amarok_storage-" #libname ) )

1) no idea (after a bit of searching) where factory ever was defined
2) K_EXPORT_PLUGIN is deprecated and it seems the plugin system changed
also a bit

I found:
http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/
which explains what has to be changed.
The problem:

I've tried to change the macro to K_PLUGIN_FACTORY( classname,
registerPlugin<libname>(); ) and removed K_EXPORT_PLUGIN but that
doesn't work that easy.

K_PLUGIN_FACTORY declares and defines the factory, so we would need to
move all code from our init method into the second argument of the macro.

Or, as there anyways already is a base Plugin Factory, just remove the
usage of K_PLUGIN_FACTORY and move the few lines of Code into PluginFactory.

Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150830/f6d9b10d/attachment.sig>