Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

[Myriam Schweingruber]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124773/#review83969
-----------------------------------------------------------


Sorry, but that is not acceptable that way, you are using shortcuts that are already defined on the system, like Ctrl+A, this can't be used. (FWIW: Ctrl+A is used on pretty much every system I know to select everything).

So please check again, do NOT use Standard shortcuts or already defined global ones, those already in use can be found quite easily in the systemsettings for KDE.

- Myriam Schweingruber


On Aug. 17, 2015, 9:26 a.m., Aditya Dev Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124773/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 9:26 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 300979
>     https://bugs.kde.org/show_bug.cgi?id=300979
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> JJ : Bug - 300979 : Patch to add some shortcuts for various actions in createActions() in MainWindow
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 22fb8ce 
> 
> Diff: https://git.reviewboard.kde.org/r/124773/diff/
> 
> 
> Testing
> -------
> 
> Built and tested.
> 
> Initially added some more shortcuts but couldn't test them. Will have to go through the Amarok User Hand Book to see how are things supposed to go. So will update in a day or two.
> 
> Action : Shortcut --------> SLOT
> 
> Clear Playlist : CTRL + SHIFT + C  ---------------> SLOT(clear() )
> Add Stream : CTRL + A              ---------------> SLOT(slotAddStream() ) 
> Export Playlits : CTRL + SHIFT + E ---------------> SLOT(exportPlaylist() )
> Bookmarks Manager : CTRL + B       ---------------> SLOT(slotShowBookmarkManager() )
> Equalizer : SHIFT + E              ---------------> SLOT(slotShowEqualizer() )
> Cover Manager : CTRL + ALT + C     ---------------> SLOT(slotShowCoverManager() )
> Synchronize Statistics : CTRL + S  ---------------> SLOT(synchronize() )
> 
> /* Rev 2 */
> Bookmark Media Sources View : SHIFT + B ----------> SLOT(bookmarkCurrentBrowserView() )
> Bookmark Playlist Setup : ALT + B  ---------------> bookmarkCurrentPlaylistView() )
> Bookmark Context Applets : CTRL + SHIFT + B ------> bookmarkCurrentContextView() ) 
> Disable Dynamic Playlist : ALT + SHIFT + D -------> connected inside dynamic playlist category
> 
> /* Rev3 */
> About Amarok : CTRL + SHIFT + A  -----------------> SLOT(showAbout())
> Diagnostics  : CTRL + ALT + D    -----------------> SLOT(slotShowDiagnosticsDialog())
> Report bug   : ALT + SHIFT + R   -----------------> SLOT(showReportBug())
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150817/916c0ce1/attachment.html>