Review Request 124678: porting Amarok to KF5 - 3 Commits

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124678/
-----------------------------------------------------------

(Updated août 10, 2015, 2:26 matin)


Review request for Amarok.


Changes
-------

Enhanced diff: no more problem with kplugininfo, thx to demm.

Troubles with `setServicePrefixPaths()` and `KStandardDirs::locateLocal`


Repository: amarok


Description
-------

It's my first port so I would like to have an external point of view.

Other problem, in the compilation, KPluginInfo is not found:

```
/home/olivier/Projets/amarok/src/context/tools/amarokpkg.cpp:37:30: fatal error: Plasma/KPluginInfo: No such file or directory
```


Diffs (updated)
-----

  shared/collectionscanner/ScanningState.cpp 488b5ec 
  src/context/applets/wikipedia/WikipediaApplet.cpp 824e9b7 
  src/context/tools/CMakeLists.txt 1deb7f3 
  src/context/tools/amarokpkg.cpp 2ae1e93 
  src/services/lastfm/meta/LastFmMeta.cpp 46aa8fe 
  tests/TestExpression.h cfa2a0c 
  tests/TestQStringx.h 8cf14c3 
  tests/TestSmartPointerList.h 72c95aa 
  tests/TestSmartPointerList.cpp 8e9865b 

Diff: https://git.reviewboard.kde.org/r/124678/diff/


Testing
-------


Thanks,

Olivier Churlaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150810/5576a443/attachment.html>