Review Request 124678: porting Amarok to KF5 - 3 Commits

[Olivier Churlaud]

@Aroonav: it's specially for you...

tell me what I'm supposed to do with this first work (there are 3 
commits in fact).

With this I get 19% of the compilation. BUT I have the KPluginInfo 
problem, plus a

    /usr/include/kcmodule.h:29:25: fatal error: QtGui/QWidget: No such
    file or directory

that I don't understand.

Thx
Olivier


Le 10/08/2015 01:13, Olivier Churlaud a écrit :
> This is an automatically generated e-mail. To reply, visit: 
> https://git.reviewboard.kde.org/r/124678/
>
>
> Review request for Amarok.
> By Olivier Churlaud.
> *Repository: * amarok
>
>
>   Description
>
> It's my first port so I would like to have an external point of view.
>
>
> Other problem, in the compilation, KPluginInfo is not found:
>
>
> /home/olivier/Projets/amarok/src/context/tools/amarokpkg.cpp:37:30: fatal error: Plasma/KPluginInfo: No such file or directory
>
>
>   Diffs
>
>   * shared/collectionscanner/ScanningState.cpp (488b5ec)
>   * src/context/applets/wikipedia/WikipediaApplet.cpp (824e9b7)
>   * src/context/tools/CMakeLists.txt (1deb7f3)
>   * src/context/tools/amarokpkg.cpp (2ae1e93)
>   * src/services/lastfm/meta/LastFmMeta.cpp (46aa8fe)
>   * tests/TestExpression.h (cfa2a0c)
>   * tests/TestQStringx.h (8cf14c3)
>   * tests/TestSmartPointerList.h (72c95aa)
>   * tests/TestSmartPointerList.cpp (8e9865b)
>
> View Diff <https://git.reviewboard.kde.org/r/124678/diff/>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150810/4088b9e3/attachment.html>