Review Request 120930: "Flac" and "Mp3" modified to "FLAC" and "MP3" on dialog.

Matěj Laitl matej at laitl.cz
Sat Nov 1 10:06:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120930/#review69630
-----------------------------------------------------------

Ship it!


Looks good to me, thanks! Someone with commit access please push this. (please don't forget BUG, REVIEW, FIXED-IN tags)

- Matěj Laitl


On Oct. 31, 2014, 11:49 p.m., Duilio Felix wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120930/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 11:49 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 339495
>     https://bugs.kde.org/show_bug.cgi?id=339495
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
>  [Bug 339495] "Flac" partially lowercase when ripping audio CD 
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/audiocd/FormatSelectionDialog.cpp 90cbb88 
>   src/core-impl/collections/audiocd/FormatSelectionDialog.ui 9200301 
> 
> Diff: https://git.reviewboard.kde.org/r/120930/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Duilio Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20141101/66054092/attachment.html>


More information about the Amarok-devel mailing list