Review Request 118005: Amarok use wrong url to query ampache
Dan Meltzer
parallelgrapefruit at gmail.com
Thu May 8 00:39:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118005/#review57540
-----------------------------------------------------------
Out of curiousity, what version of Ampache? I can confirm that the url has /server/xml.server.php added twice, but this actually still works on ampache 3.5.0. It works with it added once too, so it's not a big change, just wondering whats different on your ampache setup.
- Dan Meltzer
On May 5, 2014, 6:29 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118005/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 6:29 p.m.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> in AmpacheServiceQueryMaker.cpp, it append server/xml.server.php twice to the request url, which is obviously wrong. I can confirm this behaviour from server side log. Simply remove one of them will fix it.
>
>
> Diffs
> -----
>
> src/services/ampache/AmpacheServiceQueryMaker.cpp b94c3b0
>
> Diff: https://git.reviewboard.kde.org/r/118005/diff/
>
>
> Testing
> -------
>
> amarok now work with ampache again.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140508/55d0b343/attachment.html>
More information about the Amarok-devel
mailing list