Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

[Albert Astals Cid]

> On May 5, 2014, 10:58 p.m., Albert Astals Cid wrote:
> > Has this been commited? Yuri can you commit it? Want me to commit it?
> 
> Yuri Chornoivan wrote:
>     I just wanted that it to be committed by the team leader (Mat?j). Please commit the patch if you find this appropriate. ;)

No no no, don't shift the "if you find this appropiate" to me, you either give it a "ship it" and take full responsability for it or should not give ship it anymore.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114752/#review57368
-----------------------------------------------------------


On Jan. 5, 2014, 2:17 p.m., Abhay Sombanshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114752/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 2:17 p.m.)
> 
> 
> Review request for Amarok and Yuri Chornoivan.
> 
> 
> Bugs: 291400
>     https://bugs.kde.org/show_bug.cgi?id=291400
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> CollectionBrowser filter dialog will now allow a length of 24 hours.
> 
> 
> Diffs
> -----
> 
>   ChangeLog 0eb03c8 
>   src/widgets/MetaQueryWidget.cpp 58601cc 
> 
> Diff: https://git.reviewboard.kde.org/r/114752/diff/
> 
> 
> Testing
> -------
> 
> works as expected.
> 
> 
> Thanks,
> 
> Abhay Sombanshi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140506/b83f82e8/attachment.html>