Review Request 114978: Bug 296049 : Implementing MediaArtStorageSpec to manage and store cached artwork

[Vedant Agarwala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114978/#review54529
-----------------------------------------------------------


This bug may be marked as a Junior Job but actually is a big task. Not difficult but long and time consuming. You should make reviews to fix the whole bug. Once that is done it makes to test and *then* to review. You should take this up as a Season of KDE task, if you can (and wish).
But these are just my two cents :)

- Vedant Agarwala


On Jan. 12, 2014, 12:36 p.m., Animesh  Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114978/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 12:36 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 296049
>     https://bugs.kde.org/show_bug.cgi?id=296049
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> I've created a new class MediaArt in CollectionScanner which would manage and store art cache files.
> 
> Tasks accomplished
> + Validation of the $XDG_CACHE_HOME/media-art directory
> + Generation of the unique and a safe file name 
>   (according to the naming guidelines mentioned in http://tinyurl.com/MediaArtStorageSpec)
> + Copying the art file to the specified cache directory
> 
> Tasks pending
> # Local media art storage should be implemented when removable media is encountered
> # Heuristics for finding media art
> # Integration of MediaArt storage into Amarok
> 
> 
> Diffs
> -----
> 
>   shared/collectionscanner/MediaArt.h PRE-CREATION 
>   shared/collectionscanner/MediaArt.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114978/diff/
> 
> 
> Testing
> -------
> 
> Works as expected (with reference to the tasks accomplished)
> 
> 
> Thanks,
> 
> Animesh  Ramesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140329/9d16c9a1/attachment.html>