Review Request 116741: Fixed Bug 331934 (JJ- Jamendo API change causes the service not to work anymore) and corrects update button behaviour

[Vedant Agarwala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116741/#review54147
-----------------------------------------------------------


I have tested the patch. Works. Jamendo file is successfully downloaded. Also, the download button behavior seems more correct. I repeated Yash's way of testing (closing internet connection) and got the same results. Seems to fix two bugs, one filed and another that was not filled.

- Vedant Agarwala


On March 11, 2014, 8:45 p.m., yash ladia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116741/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 8:45 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 331934
>     https://bugs.kde.org/show_bug.cgi?id=331934
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> I have corrected the URL to the new one.
> Also, when there was an error in downloading the relatively large (17.3 mb) file, it just used to quit silently. With my patch it still does, but the "update" button becomes enabled so that the download can be attempted again without restarting Amarok. I had to make sure that the 'm_listDownloadJob = 0;' (line 205) was called so I placed it before the return statement. Otherwise, it was giving a segfault error when Amarok was being quit.
> 
> 
> Diffs
> -----
> 
>   src/services/jamendo/JamendoService.cpp e4a7ecc 
>   src/services/jamendo/JamendoXmlParser.h 6bdc67d 
> 
> Diff: https://git.reviewboard.kde.org/r/116741/diff/
> 
> 
> Testing
> -------
> 
> Jamendo works now. File downloads as expected.
> Also, I testing the working of the new update button behavior by running the update without any internet connection. The "update" button became enabled in this case.
> 
> 
> Thanks,
> 
> yash ladia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140326/6b9703df/attachment.html>