Review Request 118861: GSoC Review 1: parsing and highlighting of lyrics

[Vedant Agarwala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118861/
-----------------------------------------------------------

(Updated June 23, 2014, 9:49 a.m.)


Review request for Amarok.


Changes
-------

Fixed issues


Repository: amarok


Description
-------

I have been working on my project since some time and have had to make changes as I went on. I decided to get the highlighting working first then we could get to make it more pleasing.

So right now, I am able to parse LRC files and highlight the line in the present lyrics display applet itself. The text is just "selected" as the song progresses. 2 buttons increase and decrease the offset so that one can sync the line with track. This data is saved to the database (and file, if user allows).


Diffs (updated)
-----

  src/context/applets/lyrics/LrcParser.h PRE-CREATION 
  src/context/applets/lyrics/LrcParser.cpp PRE-CREATION 
  src/context/applets/lyrics/LyricsApplet.cpp 829a166 

Diff: https://git.reviewboard.kde.org/r/118861/diff/


Testing
-------

Yes.

To test it, just right-click on a track ->"edit track details"->"lyrics" and paste the lyrics with timestamps i.e. the contents of a LRC file. As soon as that track starts playing, the lyrics applet will strip the timestamps, show the lyrics and highlight them.


Thanks,

Vedant Agarwala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140623/1964bdb8/attachment.html>