Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119429/#review62969
-----------------------------------------------------------

Ship it!


Looks good to me, ship it and thanks. :)

- Matěj Laitl


On July 23, 2014, 5:07 p.m., Robert Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119429/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 5:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 337725
>     https://bugs.kde.org/show_bug.cgi?id=337725
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
>  [Bug 337725] Text for RandomBiasFactory says 'random tracks' but the text once added is 'random songs'
> 
> 
> Diffs
> -----
> 
>   src/dynamic/Bias.cpp d0aab75 
>   src/dynamic/biases/SearchQueryBias.cpp cfe4b01 
> 
> Diff: https://git.reviewboard.kde.org/r/119429/diff/
> 
> 
> Testing
> -------
> 
> Built (kubuntu 14.04)
> Checked that existing dynamic mode playlists with 'random songs' displays the new text
> Checked that random track addition to a playlist displays correctly.
> Checked that on running the playlist it looks like random tracks are being added
> 
> 
> Thanks,
> 
> Robert Marshall
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140723/663b40dc/attachment.html>