Review Request 119405: Stop passing -std=iso9899:1999 to CMAKE_C_FLAGS.

Matěj Laitl matej at laitl.cz
Wed Jul 23 07:26:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119405/#review62918
-----------------------------------------------------------

Ship it!


Looks good to me, push it! :)   (do you already have commit access?)

- Matěj Laitl


On July 22, 2014, 2:32 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119405/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 2:32 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This was added back when Amarok built its own SQLite copy, which was
> removed in 2008 by commit 489af24a010eaeacbaf2f82b0f07ebd3b12c0912.
> 
> And even then, kdelibs itself already sets this same flag on its own.
> 
> 
> Diffs
> -----
> 
>   src/core/CMakeLists.txt 5935c36bf03ff977b72f3bec74082ed15e39dea2 
> 
> Diff: https://git.reviewboard.kde.org/r/119405/diff/
> 
> 
> Testing
> -------
> 
> Still builds on Debian.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140723/49f8ab01/attachment.html>


More information about the Amarok-devel mailing list