Review Request 119403: Stop checking for -ldl manually.
Myriam Schweingruber
myriam at kde.org
Tue Jul 22 12:08:51 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119403/#review62867
-----------------------------------------------------------
Ship it!
Presuming you tested this thorougly :)
- Myriam Schweingruber
On July 22, 2014, 2:02 p.m., Raphael Kubo da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119403/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 2:02 p.m.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> Just use CMAKE_DL_LIBS instead, that's what it is for.
>
>
> Diffs
> -----
>
> CMakeLists.txt 1f66e1614c5019f5b53caebfc34ea7cf2043f727
> src/CMakeLists.txt aa3a51cd1a3c48beac7ffc7702cd4927ae00c46e
> src/core/CMakeLists.txt d512d187f9b889d18d039f5995398c4543a39272
>
> Diff: https://git.reviewboard.kde.org/r/119403/diff/
>
>
> Testing
> -------
>
> Still builds on Debian sid.
>
>
> Thanks,
>
> Raphael Kubo da Costa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140722/ca9cdba7/attachment.html>
More information about the Amarok-devel
mailing list