Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114752/#review46844
-----------------------------------------------------------


I see, this patch is almost ready, please wait for Yuri to answer and then fix remaining problems. Also please don't forget about:
 1. Add commit tags to the description - see quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template - namely: BUG: ####, FIXED-IN: 2.9, REVIEW: ### - so that they end up in the commit - also please update the description to be current


src/widgets/MetaQueryWidget.cpp
<https://git.reviewboard.kde.org/r/114752/#comment33442>

    So the maximum time is 23:59:59 - this calculation is wrong.



src/widgets/MetaQueryWidget.cpp
<https://git.reviewboard.kde.org/r/114752/#comment33443>

    Please:
     1. provide context for the string - use i18nc() call with context like "time format for specifying track length - hours, minutes, seconds"
     2. respect Amarok coding style - spaces around arguments


- Matěj Laitl


On Jan. 5, 2014, 11:25 a.m., Abhay Sombanshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114752/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 11:25 a.m.)
> 
> 
> Review request for Amarok and Yuri Chornoivan.
> 
> 
> Bugs: 291400
>     https://bugs.kde.org/show_bug.cgi?id=291400
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> CollectionBrowser filter dialog will now allow a length of 24 hours.
> 
> 
> Diffs
> -----
> 
>   ChangeLog 0eb03c8 
>   src/widgets/MetaQueryWidget.cpp 58601cc 
> 
> Diff: https://git.reviewboard.kde.org/r/114752/diff/
> 
> 
> Testing
> -------
> 
> works as expected.
> 
> 
> Thanks,
> 
> Abhay Sombanshi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140105/f57a8522/attachment.html>