Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

[Abhay Sombanshi]

> On Jan. 4, 2014, 9:28 p.m., Matěj Laitl wrote:
> > src/widgets/MetaQueryWidget.cpp, line 850
> > <https://git.reviewboard.kde.org/r/114752/diff/2/?file=229709#file229709line850>
> >
> >     I see no point in allowing only 23:59:59, just make it 24:00:00 please, unless there is a usability problem with it. (and please update other places to match)

The maximum allowed value in QTime is 23:59:59 hours.


- Abhay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114752/#review46778
-----------------------------------------------------------


On Jan. 3, 2014, 11:03 p.m., Abhay Sombanshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114752/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 11:03 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 291400
>     https://bugs.kde.org/show_bug.cgi?id=291400
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> CollectionBrowser filter dialog will now allow a length of 2:59:59 hours.
> 
> 
> Diffs
> -----
> 
>   src/widgets/MetaQueryWidget.cpp 58601cc 
> 
> Diff: https://git.reviewboard.kde.org/r/114752/diff/
> 
> 
> Testing
> -------
> 
> works as expected.
> 
> 
> Thanks,
> 
> Abhay Sombanshi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140104/b739eb04/attachment.html>