Review Request 114736: Bug 299431 The text in the notification area located in the lower left corner is cut when copying several tracks to the collection at the same time.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114736/#review46687
-----------------------------------------------------------


Hi, the patch looks very good, thanks for it!

To help us even more, please:
 1. attach a screenshot here (similar to the attachment of bug https://bugs.kde.org/show_bug.cgi?id=299431 ) showing how the problem is fixed
 2. Add commit tags to the description - see quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template - namely: BUG: ####, FIXED-IN: 2.9, REVIEW: ### - so that they end up in the commit
 3. Add a line to the ChangeLog file (top-level in the repo) - under BUGFIXES on top.


src/statusbar/ProgressBar.cpp
<https://git.reviewboard.kde.org/r/114736/#comment33330>

    Please respect Amarok coding style (see folder named HACKING) - spaces around arguments.


- Matěj Laitl


On Dec. 30, 2013, 7:20 a.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114736/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 7:20 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 299431
>     https://bugs.kde.org/show_bug.cgi?id=299431
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> QLabel for CompoundProgressbar was croping out the description from above and below because QLabel default alignment is set to Horizontal left and vertical Center.Changed to Vertical Top.Added Ellipsis for text overflow and tooltip to view the description
> 
> 
> Diffs
> -----
> 
>   src/statusbar/ProgressBar.cpp 400390f 
> 
> Diff: https://git.reviewboard.kde.org/r/114736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140103/1f830e13/attachment-0001.html>