Review Request 110036: WIP - Simple equalizer scripting

[Matěj Laitl]

> On July 2, 2013, 12:50 p.m., Mark Kretschmann wrote:
> > Any news on this? Could you please upload the patch again?

There has been no feedback for 6 months and I believe this could have been superseded by Scripting GSoC 2013 project -> should this be discarded?


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110036/#review35436
-----------------------------------------------------------


On April 18, 2013, 10:03 a.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110036/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 10:03 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> A new, unambitious attempt at adding equalizer functions to the scripting interface.
> 
> Adds to EngineController the functions:
> * QString eqPreset()
> * void eqApplyPreset(QString name)
> And the signal:
> eqPresetApplied(QString name)
> 
> Adds to AmarokEngineScript the same functions
> set up as a property.
> 
> 
> Diffs
> -----
> 
>   src/EngineController.cpp 28fb256 
>   src/scriptengine/AmarokEngineScript.h f1cdb8c 
>   src/scriptengine/AmarokEngineScript.cpp 4d52bbe 
>   src/EngineController.h 5de4beb 
> 
> Diff: https://git.reviewboard.kde.org/r/110036/diff/
> 
> 
> Testing
> -------
> 
> Quick check using the script console that presets can be changed.
> The preset does get applied but it won't show in the EqualizerDialog.
> Possible other bugs.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140103/78792442/attachment.html>