Review Request 121564: Add git submodules referencing gtest and gmock.

Konrad Zemek konrad.zemek at gmail.com
Wed Dec 17 18:20:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121564/
-----------------------------------------------------------

(Updated Dec. 17, 2014, 6:20 p.m.)


Review request for Amarok.


Changes
-------

Change docs after changes in fetching gmock.


Repository: amarok


Description
-------

The submodules are used to build googlemock for linking with test
suites. The submodules are intended to be fetched by a user through
`git submodule` commands, but for convenience can also be automatically
fetched when processing tests' CMakeLists.txt .

If the simple logic in CMakeLists.txt determines that the submodules
couldn't be fetched, it aborts configuration with a meaningful error
message.


Diffs (updated)
-----

  HACKING/building_amarok2_in_home.txt 01ab5a7 
  README 32e4824 

Diff: https://git.reviewboard.kde.org/r/121564/diff/


Testing
-------

Compilation with and without testing enabled, with and without git available. Release build done with help of releaseme.git:amarok2.rb script.


Thanks,

Konrad Zemek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20141217/29dea7b1/attachment.html>


More information about the Amarok-devel mailing list