Review Request 121250: SoK Implement Cuesheet Support

[Vedant Agarwala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121250/#review71458
-----------------------------------------------------------


Make sure to comment here rather than replying to the mailing list email


shared/collectionscanner/CueSheet.h
<https://git.reviewboard.kde.org/r/121250/#comment49856>

    Do not include headers that you aren't going to use.
    
    You use it in CueSheet.cpp so include it there only.


- Vedant Agarwala


On Dec. 4, 2014, 11:52 p.m., Nitul Datt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121250/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 11:52 p.m.)
> 
> 
> Review request for Amarok and Vedant Agarwala.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This is an initial implementation for a CueSheet class in the CollectionScanner. There are some errors though, which have yet to be sorted out.
> 
> 
> Diffs
> -----
> 
>   shared/CMakeLists.txt 31ca0f4 
>   shared/collectionscanner/CueSheet.h PRE-CREATION 
>   shared/collectionscanner/CueSheet.cpp PRE-CREATION 
>   shared/collectionscanner/Directory.h faacce4 
>   shared/collectionscanner/Directory.cpp a65884b 
> 
> Diff: https://git.reviewboard.kde.org/r/121250/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitul Datt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20141206/689d7eda/attachment.html>