Review Request 119848: Fix for BUG 251199 -- Specifically for two context applets, Wikipedia and Lyrics

[Prasad Bhat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119848/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 1:06 p.m.)


Review request for Amarok.


Changes
-------

Variable m_enabled in LyricsEngine was not initialized in constructor. Now it is.


Bugs: 251199
    https://bugs.kde.org/show_bug.cgi?id=251199


Repository: amarok


Description
-------

This patch does the following -
1. Creates a way to channel the window activation/deactivation events to Context::Applet
2. Enable/disable setup for Wikipedia and Lyrics applets and corresponding engines


Diffs (updated)
-----

  src/context/Applet.h 55f95d9 
  src/context/Applet.cpp 0d0fe4e 
  src/context/LyricsManager.h 940fb78 
  src/context/applets/lyrics/LyricsApplet.h 20c71d8 
  src/context/applets/lyrics/LyricsApplet.cpp 829a166 
  src/context/applets/wikipedia/WikipediaApplet.h 9663ae3 
  src/context/applets/wikipedia/WikipediaApplet.cpp 21365f2 
  src/context/engines/lyrics/LyricsEngine.h 97cf413 
  src/context/engines/lyrics/LyricsEngine.cpp 2b78e70 
  src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 

Diff: https://git.reviewboard.kde.org/r/119848/diff/


Testing
-------


Thanks,

Prasad Bhat

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140820/9bcad691/attachment.html>