Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

[Alex Busenius]

> On Sept. 18, 2013, 9:46 p.m., Alex Merry wrote:
> > I'm torn between following Amarok's internals (which you do) and following MPRIS2, meaning it should be called UserRating and return/allow a double between 0.0 and 1.0.
> > 
> > There's also the question of how urgent this is, as there's discussion on the MPRIS list (which had stalled for a few months, but I started up again) about adding a general way of editing Metadata entries.
> 
> Alex Busenius wrote:
>     I don't see anyy sign of UserRating in MPRIS2 specs: http://specifications.freedesktop.org/mpris-spec/latest/... Can you point me to the right place? If there is a more standard way to set rating, I would prefer doing it that way.
>     
>     A general way of editing metadata would be great, but would it not be better to handle rating differently (e.g. standardize range 0.0 ... 1.0 and let applications map their understanding of rating into that range)?
> 
> Alex Merry wrote:
>     http://www.freedesktop.org/wiki/Specifications/mpris-spec/metadata/#index22h4 (xesam:userRating), linked to from http://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html#Mapping:Metadata_Map
>     
>     So my point here is that MPRIS has "user rating" and "auto rating", while Amarok has "rating" and "score".  MPRIS standardises both ratings to be in the range 0.0 to 1.0, while Amarok has the user rating be an integer number between 0 and 10.  The question is, should an Amarok extension to the MPRIS interface follow the MPRIS conventions or the Amarok conventions?  I'm leaning slightly towards following the MPRIS conventions.

+1 for MPRIS conventions


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112802/#review40313
-----------------------------------------------------------


On Sept. 18, 2013, 7:34 p.m., Alex Busenius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112802/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 7:34 p.m.)
> 
> 
> Review request for Amarok and Alex Merry.
> 
> 
> Description
> -------
> 
> The D-Bus interface is currently missing convenient method for reading and setting user rating (the stars). The proposed patch adds an Mpris2 extension to /org/mpris/MediaPlayer2 for that: 
> 
> property readwrite int org.kde.amarok.Mpris2Extensions.Player.Rating
> 
> 
> Diffs
> -----
> 
>   src/dbus/mpris2/MediaPlayer2AmarokExtensions.h 964c7b8 
>   src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp ba8b54e 
>   src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml 3397df4 
> 
> Diff: http://git.reviewboard.kde.org/r/112802/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Busenius
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130923/12bf67a8/attachment.html>