Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

[Myriam Schweingruber]

> On Sept. 19, 2013, 3:48 p.m., Matěj Laitl wrote:
> >

I am just wondering: since Amarok doesn't play APE tracks anyway, why bother? AFAIK there is no phonon backend currently that provides the MAC codec, and ape files shouldn't even show up in the collection folder, as neither the vlc nor gstreamer backends do support playing these files.


- Myriam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112815/#review40349
-----------------------------------------------------------


On Sept. 19, 2013, 3:12 p.m., Bruno Léon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112815/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 3:12 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Properly fix read compilation tag in APE (musepack...) files
> 
> Previous patch 5e5140b was not complete. The information was read but not inserted in the data structure and thus not inserted in Aamrok DB.
> 
> 
> Diffs
> -----
> 
>   shared/tag_helpers/APETagHelper.cpp ba39a10 
> 
> Diff: http://git.reviewboard.kde.org/r/112815/diff/
> 
> 
> Testing
> -------
> 
> Files that were not placed in Various Artists before are now correctly recognised as compilation.
> 
> 
> Thanks,
> 
> Bruno Léon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130923/8605bf4d/attachment.html>