Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112815/#review40349
-----------------------------------------------------------



shared/tag_helpers/APETagHelper.cpp
<http://git.reviewboard.kde.org/r/112815/#comment29769>

    Shouldn't that be toBool()
    isCompilation is AFAIK a boolean value.


- Matěj Laitl


On Sept. 19, 2013, 3:12 p.m., Bruno Léon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112815/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 3:12 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Properly fix read compilation tag in APE (musepack...) files
> 
> Previous patch 5e5140b was not complete. The information was read but not inserted in the data structure and thus not inserted in Aamrok DB.
> 
> 
> Diffs
> -----
> 
>   shared/tag_helpers/APETagHelper.cpp ba39a10 
> 
> Diff: http://git.reviewboard.kde.org/r/112815/diff/
> 
> 
> Testing
> -------
> 
> Files that were not placed in Various Artists before are now correctly recognised as compilation.
> 
> 
> Thanks,
> 
> Bruno Léon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130919/87270241/attachment.html>