Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

Alex Busenius alex.busenius at gmail.com
Wed Sep 18 19:34:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112802/
-----------------------------------------------------------

Review request for Amarok and Alex Merry.


Summary (updated)
-----------------

Extend dbus unterface for reading and writing the rating of the current song


Description (updated)
-------

The D-Bus interface is currently missing convenient method for reading and setting user rating (the stars). The proposed patch adds an Mpris2 extension to /org/mpris/MediaPlayer2 for that: 

property readwrite int org.kde.amarok.Mpris2Extensions.Player.Rating


Diffs (updated)
-----

  src/dbus/mpris2/MediaPlayer2AmarokExtensions.h 964c7b8 
  src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp ba8b54e 
  src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml 3397df4 

Diff: http://git.reviewboard.kde.org/r/112802/diff/


Testing
-------


Thanks,

Alex Busenius

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130918/e6fcbc34/attachment.html>


More information about the Amarok-devel mailing list