Review Request 112706: Allow to use Wikipedia over SSL

[Frank Meerkoetter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112706/
-----------------------------------------------------------

(Updated Sept. 12, 2013, 8:44 p.m.)


Review request for Amarok.


Changes
-------

Updated patch after review


Description
-------

Allow to use wikipedia over SSL. Make encrypted connections the default. Add an option to fall back to plain HTTP.


This addresses bug 322249.
    https://bugs.kde.org/show_bug.cgi?id=322249


Diffs (updated)
-----

  src/context/applets/wikipedia/WikipediaApplet.cpp 507db96 
  src/context/applets/wikipedia/WikipediaApplet_p.h c52a0bf 
  src/context/applets/wikipedia/wikipediaGeneralSettings.ui a615dee 
  src/context/engines/wikipedia/WikipediaEngine.cpp f22e443 

Diff: http://git.reviewboard.kde.org/r/112706/diff/


Testing
-------

Switched several times between HTTP and HTTPS. Switched between the normal and the mobile version.
Checked the traffic with wireshark. Verified that this setting is actually persisted.


Thanks,

Frank Meerkoetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130912/96c6a3b5/attachment.html>