Review Request 111212: Kill long running scripts

[Anmol Ahuja]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111212/
-----------------------------------------------------------

(Updated Oct. 23, 2013, 12:39 a.m.)


Status
------

This change has been discarded.


Review request for Amarok.


Repository: amarok


Description
-------

Added the ability to kill a long running script.
Refactored a bit.


Diffs
-----

  src/scriptengine/AmarokScriptableServiceScript.cpp a312671 
  src/ScriptManager.cpp ab09fcf 
  src/ScriptManager.h afaa832 

Diff: http://git.reviewboard.kde.org/r/111212/diff/


Testing
-------


File Attachments
----------------

script
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/benchmark.zip


Thanks,

Anmol Ahuja

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131022/ea1c6610/attachment.html>