Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

Anmol Ahuja darthcodus at gmail.com
Tue Oct 22 19:07:56 UTC 2013 


> On Oct. 20, 2013, 7:06 p.m., Matěj Laitl wrote:
> > Thanks for finally posting this patch, please give me a couple of days to review it.
> 
> Matěj Laitl wrote:
>     I guess this review could be discarded because you've resubmitted it in multiple parts?

yep, I'll discard it plus some other older reviews.


- Anmol


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113356/#review42014
-----------------------------------------------------------


On Oct. 20, 2013, 6:43 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113356/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2013, 6:43 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Changes made as part of my GSoC project.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fa1ab0c 
>   cmake/modules/FindQtScriptQtBindings.cmake bd24328 
>   cmake/modules/bindingstest/QtScriptBindingsTest.cpp 424556f 
>   shared/MetaTagLib.h 2de3be2 
>   shared/MetaTagLib.cpp d42dd32 
>   shared/MetaValues.h 4b003ed 
>   shared/tag_helpers/APETagHelper.cpp ba39a10 
>   shared/tag_helpers/ASFTagHelper.cpp 3439845 
>   shared/tag_helpers/ID3v2TagHelper.h a9c9ab9 
>   shared/tag_helpers/ID3v2TagHelper.cpp 03a3836 
>   shared/tag_helpers/MP4TagHelper.cpp 23d8879 
>   shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 
>   src/App.h 9ee071d 
>   src/App.cpp eb3f483 
>   src/CMakeLists.txt 70fb67b 
>   src/EngineController.h 80ec17b 
>   src/EngineController.cpp cf29cf8 
>   src/ScriptManager.h 1a252ca 
>   src/ScriptManager.cpp 04b8eef 
>   src/ScriptUpdater.h 0e9b37d 
>   src/ScriptUpdater.cpp f174248 
>   src/amarokconfig.kcfg 84cfa5b 
>   src/amarokurls/BookmarkGroup.h ea42c30 
>   src/browsers/CollectionTreeItem.h 0a5d197 
>   src/browsers/CollectionTreeItem.cpp 4c35523 
>   src/browsers/CollectionTreeItemModelBase.h 00e99fb 
>   src/browsers/CollectionTreeView.h 454a70d 
>   src/browsers/CollectionTreeView.cpp 6fad164 
>   src/browsers/collectionbrowser/CollectionWidget.h 7480015 
>   src/browsers/collectionbrowser/CollectionWidget.cpp 95a16dc 
>   src/configdialog/dialogs/ScriptSelector.h 9ce1168 
>   src/configdialog/dialogs/ScriptSelector.cpp 117cedf 
>   src/configdialog/dialogs/ScriptsConfig.h 6a47847 
>   src/configdialog/dialogs/ScriptsConfig.cpp 714b63e 
>   src/configdialog/dialogs/ScriptsConfig.ui b4b8d37 
>   src/context/applets/lyrics/LyricsApplet.cpp 7db356d 
>   src/context/applets/songkick/SongkickApplet.cpp ed93e56 
>   src/context/engines/lyrics/LyricsEngine.cpp d3273b0 
>   src/core-impl/collections/support/jobs/WriteTagsJob.h a92ab8d 
>   src/core-impl/collections/support/jobs/WriteTagsJob.cpp 5834cd4 
>   src/core/collections/Collection.h 94d24d7 
>   src/core/collections/QueryMaker.h 92b6a65 
>   src/core/meta/support/MetaConstants.cpp 40d7122 
>   src/dialogs/DiagnosticDialog.cpp c9bfce6 
>   src/dialogs/EqualizerDialog.h 6c9e19e 
>   src/dialogs/EqualizerDialog.cpp acf0da0 
>   src/dialogs/deviceconfiguredialog.cpp e54edad 
>   src/dynamic/BiasFactory.cpp 2a887c2 
>   src/dynamic/TrackSet.h dee8ee3 
>   src/dynamic/TrackSet.cpp 456a10a 
>   src/equalizer/EqualizerPresets.h be8d267 
>   src/equalizer/EqualizerPresets.cpp b9aa13b 
>   src/playback/EqualizerController.h PRE-CREATION 
>   src/playback/EqualizerController.cpp PRE-CREATION 
>   src/playlistmanager/PlaylistManager.h a835c35 
>   src/scriptengine/AmarokCollectionScript.h 224bd54 
>   src/scriptengine/AmarokCollectionScript.cpp 3fcda84 
>   src/scriptengine/AmarokEngineScript.h aa2b112 
>   src/scriptengine/AmarokEngineScript.cpp 5471838 
>   src/scriptengine/AmarokInfoScript.h 754498e 
>   src/scriptengine/AmarokInfoScript.cpp 4d06568 
>   src/scriptengine/AmarokKNotifyScript.h 720f9f6 
>   src/scriptengine/AmarokKNotifyScript.cpp b98efed 
>   src/scriptengine/AmarokLyricsScript.h a47c609 
>   src/scriptengine/AmarokLyricsScript.cpp b1972fa 
>   src/scriptengine/AmarokNetworkScript.h 785a645 
>   src/scriptengine/AmarokNetworkScript.cpp 0eaa440 
>   src/scriptengine/AmarokOSDScript.h 992fcee 
>   src/scriptengine/AmarokOSDScript.cpp 659cd68 
>   src/scriptengine/AmarokPlaylistScript.h a9df74e 
>   src/scriptengine/AmarokPlaylistScript.cpp 2dde634 
>   src/scriptengine/AmarokScript.h 4ec6d8f 
>   src/scriptengine/AmarokScript.cpp b21a2ec 
>   src/scriptengine/AmarokScriptConfig.h a77418f 
>   src/scriptengine/AmarokScriptConfig.cpp 457104a 
>   src/scriptengine/AmarokScriptableServiceScript.h 6afacfa 
>   src/scriptengine/AmarokScriptableServiceScript.cpp a312671 
>   src/scriptengine/AmarokServicePluginManagerScript.h ed7f307 
>   src/scriptengine/AmarokServicePluginManagerScript.cpp 86f841c 
>   src/scriptengine/AmarokStatusbarScript.h c871213 
>   src/scriptengine/AmarokStatusbarScript.cpp 6efbb38 
>   src/scriptengine/AmarokWindowScript.h 5b18e18 
>   src/scriptengine/AmarokWindowScript.cpp c9a65ee 
>   src/scriptengine/MetaTypeExporter.h ec961e8 
>   src/scriptengine/MetaTypeExporter.cpp d832181 
>   src/scriptengine/ScriptImporter.h 7ae9155 
>   src/scriptengine/ScriptImporter.cpp 672cd24 
>   src/scripting/scriptconsole/CompletionModel.h PRE-CREATION 
>   src/scripting/scriptconsole/CompletionModel.cpp PRE-CREATION 
>   src/scripting/scriptconsole/ScriptConsole.h PRE-CREATION 
>   src/scripting/scriptconsole/ScriptConsole.cpp PRE-CREATION 
>   src/scripting/scriptconsole/ScriptConsoleItem.h PRE-CREATION 
>   src/scripting/scriptconsole/ScriptConsoleItem.cpp PRE-CREATION 
>   src/scripting/scriptconsole/ScriptEditorDocument.h PRE-CREATION 
>   src/scripting/scriptconsole/ScriptEditorDocument.cpp PRE-CREATION 
>   src/scripting/scriptengine/AmarokBookmarkScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokBookmarkScript.cpp PRE-CREATION 
>   src/scripting/scriptengine/AmarokCollectionScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokCollectionViewScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokCollectionViewScript.cpp PRE-CREATION 
>   src/scripting/scriptengine/AmarokEqualizerScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokEqualizerScript.cpp PRE-CREATION 
>   src/scripting/scriptengine/AmarokNetworkScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokPlaylistManagerScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokPlaylistManagerScript.cpp PRE-CREATION 
>   src/scripting/scriptengine/AmarokPlaylistScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokScriptableServiceScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokStreamItemScript.h PRE-CREATION 
>   src/scripting/scriptengine/AmarokStreamItemScript.cpp PRE-CREATION 
>   src/scripting/scriptengine/AmarokWindowScript.cpp PRE-CREATION 
>   src/scripting/scriptengine/PHAACG2.py PRE-CREATION 
>   src/scripting/scriptengine/ScriptingDefines.h PRE-CREATION 
>   src/scripting/scriptengine/ScriptingDefines.cpp PRE-CREATION 
>   src/scripting/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION 
>   src/scripting/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION 
>   src/scripting/scriptengine/exporters/MetaTypeExporter.h PRE-CREATION 
>   src/scripting/scriptengine/exporters/MetaTypeExporter.cpp PRE-CREATION 
>   src/scripting/scriptengine/exporters/PlaylistExporter.h PRE-CREATION 
>   src/scripting/scriptengine/exporters/PlaylistExporter.cpp PRE-CREATION 
>   src/scripting/scriptengine/exporters/PlaylistProviderExporter.h PRE-CREATION 
>   src/scripting/scriptengine/exporters/PlaylistProviderExporter.cpp PRE-CREATION 
>   src/scripting/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION 
>   src/scripting/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION 
>   src/scripting/scriptengine/exporters/ScriptableBiasExporter.h PRE-CREATION 
>   src/scripting/scriptengine/exporters/ScriptableBiasExporter.cpp PRE-CREATION 
>   src/scripting/scriptmanager/ScriptItem.h PRE-CREATION 
>   src/scripting/scriptmanager/ScriptItem.cpp PRE-CREATION 
>   src/scripts/CMakeLists.txt  
>   src/scripts/ScriptWriting-HOWTO  
>   src/scripts/librivox_service/CMakeLists.txt  
>   src/scripts/librivox_service/COPYING  
>   src/scripts/librivox_service/LibrivoxEmblem.png  
>   src/scripts/librivox_service/LibrivoxIcon.png  
>   src/scripts/librivox_service/LibrivoxLogo.png  
>   src/scripts/librivox_service/LibrivoxScalableEmblem.svgz  
>   src/scripts/librivox_service/LibrivoxService.html  
>   src/scripts/librivox_service/README  
>   src/scripts/librivox_service/audio_book.svgz  
>   src/scripts/librivox_service/audio_book128.png  
>   src/scripts/librivox_service/audio_book16.png  
>   src/scripts/librivox_service/audio_book22.png  
>   src/scripts/librivox_service/audio_book32.png  
>   src/scripts/librivox_service/audio_book48.png  
>   src/scripts/librivox_service/audio_book64.png  
>   src/scripts/librivox_service/main.js 06035af 
>   src/scripts/librivox_service/script.spec 26719d5 
>   src/scripts/lyrics_lyricwiki/CMakeLists.txt  
>   src/scripts/lyrics_lyricwiki/main.js 08a3701 
>   src/scripts/lyrics_lyricwiki/script.spec d3346dc 
>   src/scripts/qtscript_debug/CMakeLists.txt  
>   src/scripts/qtscript_debug/debug/debug.js  
>   src/scripts/qtscript_debug/main.js  
>   src/scripts/qtscript_debug/script.spec  
>   src/scripts/radio_station_service/CMakeLists.txt  
>   src/scripts/radio_station_service/main.js  
>   src/scripts/radio_station_service/script.spec  
>   src/scripts/script_console/CMakeLists.txt  
>   src/scripts/script_console/main.js  
>   src/scripts/script_console/script.spec  
>   src/scripts/templates/CMakeLists.txt  
>   src/scripts/templates/script.spec  
>   src/scripts/templates/template.js  
>   src/scripts/webcontrol/CMakeLists.txt  
>   src/scripts/webcontrol/main.js  
>   src/scripts/webcontrol/script.spec  
>   src/services/scriptable/ScriptableService.cpp f254e3e 
>   src/services/scriptable/ScriptableServiceInfoParser.cpp 998135b 
>   src/services/scriptable/ScriptableServiceManager.cpp aa28a6c 
>   src/services/scriptable/ScriptableServiceQueryMaker.cpp 07233dd 
> 
> Diff: http://git.reviewboard.kde.org/r/113356/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131022/c3891f84/attachment-0001.html>

More information about the Amarok-devel mailing list