Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113346/#review41993
-----------------------------------------------------------



File Attachment: Transcoding dialog with the note. - snapshot1.png
<http://git.reviewboard.kde.org//r/113346/#fcomment119>
    I'd say the note could look better under (rather than above) the Transcode group box.


src/transcoding/TranscodingAssistantDialog.cpp
<http://git.reviewboard.kde.org/r/113346/#comment30649>

    This can be simplified to:
    
    ui.groupBox->setEnabled( !available.isEmpty() );
    ui.encoderNotFoundLabel->setVisible( available.isEmpty );
    
    Notice that we prefer the "positive" names rather than the negative: visible/hidden, enabled/disabled. It is easier for brain.



src/transcoding/TranscodingAssistantDialog.ui
<http://git.reviewboard.kde.org/r/113346/#comment30648>

    I don't think you need to play with the label's enabled property, just show/hide it.



src/transcoding/TranscodingAssistantDialog.ui
<http://git.reviewboard.kde.org/r/113346/#comment30650>

    Proposed wording:
    
    <b>Note:</b> No encoder is available. If you want to transcode tracks please install <i>ffmpeg</i> or <i>libav</i> package (with <i>ffmpeg</i> wrapper) with appropriate encoders. Otherwise you may check <i>Remember this choice for the next time</i> option in order to skip this dialog for future transfers.
    
    Also please remove the notr="true" property, it must be left to default (false) to make this string translatable.


- Matěj Laitl


On Oct. 19, 2013, 9:48 p.m., Jai  Luthra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113346/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2013, 9:48 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 317902
>     https://bugs.kde.org/show_bug.cgi?id=317902
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> When ffmpeg is not available, the transcoding dialog will not be skipped; rather it will add a note for the user to install an encoder.
> 
> 
> Diffs
> -----
> 
>   src/core/collections/CollectionLocation.cpp 2385570 
>   src/transcoding/TranscodingAssistantDialog.cpp 17fc250 
>   src/transcoding/TranscodingAssistantDialog.ui 0ad83b2 
> 
> Diff: http://git.reviewboard.kde.org/r/113346/diff/
> 
> 
> Testing
> -------
> 
> * Compiles
> * Works as expected
> 
> 
> File Attachments
> ----------------
> 
> Transcoding dialog with the note.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/424771d9-a0ae-4eaf-824b-4b6bd2b840ee__snapshot1.png
> 
> 
> Thanks,
> 
> Jai  Luthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131019/87ac26a5/attachment.html>